Mobile improvements #587
Closed
Mobile improvements #587
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some research and suspect this won't work properly on Android. According to this article, Chrome for Android won't get a keyboard at all. The article is a little dated, admittedly. Generally speaking, the docs are clear this is meant to be used only when the app renders its own keyboard. Even though it might have the desired effect, I'm concerned this approach will have issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: these changes have only been tested on Safari and Chrome on iOS
To prevent the keyboard from popping up by default I use the
inputmodeattribute which signals to the browser which virtual keyboard to display (eg:inputmode=numericmay show the 'keypad' instead of a typical keyboard). Setting this tononetells the browser not to display any keyboard. In this case, mobile users will need to tap input fields to show a keyboard. Since desktop users use hardware keyboards they are unaffected. Closes #424